diff options
| author | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2014-03-18 15:30:26 +1100 |
|---|---|---|
| committer | Eli Qiao <taget@linux.vnet.ibm.com> | 2014-03-19 10:23:01 +0800 |
| commit | 6d08cb7dd46529a4943f19430540bef3c967c13f (patch) | |
| tree | c1f71a8d81747fec3771276e054822276b2d7a49 | |
| parent | 803b6820b0acf3c2d6b57273258a4135da506f56 (diff) | |
| download | powerpc-6d08cb7dd46529a4943f19430540bef3c967c13f.tar.gz | |
ipr: qc_fill_rtf() method should not store alternate status register
The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e.
it is not intended for storing the alternate status register (which is mapped
at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
not do this as well...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/ipr.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index a87767f73913dd..0d431769f6631a 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_queued_cmd *qc) tf->hob_lbal = g->hob_lbal; tf->hob_lbam = g->hob_lbam; tf->hob_lbah = g->hob_lbah; - tf->ctl = g->alt_status; return true; } |