diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-07-02 14:27:35 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-06 17:37:31 +0200 |
| commit | c5fae4f4fd28189b1062fb8ef7b21fec37cb8b17 (patch) | |
| tree | 3b6b7867156767dfa458939e1d81f17599bf27b5 | |
| parent | c37a192ef442fc34e9aa7c9e479f20eb4cd6f7af (diff) | |
| download | staging-c5fae4f4fd28189b1062fb8ef7b21fec37cb8b17.tar.gz | |
staging: rts5208: fix missing error check on call to rtsx_write_register
Currently the check on error return from the call to rtsx_write_register
is checking the error status from the previous call. Fix this by adding
in the missing assignment of retval.
Detected by CoverityScan, CID#709877
Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/rts5208/sd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index f2778abf10c08..e7efa34195c7b 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@ -4690,7 +4690,7 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip) goto sd_execute_write_cmd_failed; } - rtsx_write_register(chip, SD_BYTE_CNT_L, 0xFF, 0x00); + retval = rtsx_write_register(chip, SD_BYTE_CNT_L, 0xFF, 0x00); if (retval != STATUS_SUCCESS) { goto sd_execute_write_cmd_failed; } |