diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2012-09-02 21:46:10 +0200 |
|---|---|---|
| committer | John Kacur <jkacur@redhat.com> | 2012-10-17 00:21:52 +0200 |
| commit | 954e01fe14374466964bed63769cfcf6a98f2aa1 (patch) | |
| tree | d779548f91a4c2fdafb282a3e4345c1a0a615279 | |
| parent | d63f567c646e07da87d9ce3cce5e5add74c97e16 (diff) | |
| download | rt-tests-954e01fe14374466964bed63769cfcf6a98f2aa1.tar.gz | |
rt-tests: have printf use %s format for strings
Discovered while compiling with "hardening flags"
For Debian 7.0 (aka wheezy) packages it's recommended to use several
hardening flags, the default on amd64 being:
CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security
CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-z,relro
This patch doesn't fix all warnings but at least makes all programs compile
again by not using char *variables as printf format strings.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: John Kacur <jkacur@redhat.com>
| -rw-r--r-- | src/pmqtest/pmqtest.c | 4 | ||||
| -rw-r--r-- | src/ptsematest/ptsematest.c | 4 | ||||
| -rw-r--r-- | src/sigwaittest/sigwaittest.c | 4 | ||||
| -rw-r--r-- | src/svsematest/svsematest.c | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/src/pmqtest/pmqtest.c b/src/pmqtest/pmqtest.c index b811d95..336a8eb 100644 --- a/src/pmqtest/pmqtest.c +++ b/src/pmqtest/pmqtest.c @@ -512,12 +512,12 @@ int main(int argc, char *argv[]) (int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5), receiver[i].maxdiff); if (receiver[i].error[0] != '\0') { - printf(receiver[i].error); + printf("%s", receiver[i].error); errorlines++; receiver[i].error[0] = '\0'; } if (sender[i].error[0] != '\0') { - printf(sender[i].error); + printf("%s", sender[i].error); errorlines++; receiver[i].error[0] = '\0'; } diff --git a/src/ptsematest/ptsematest.c b/src/ptsematest/ptsematest.c index 92f0ab5..7558a41 100644 --- a/src/ptsematest/ptsematest.c +++ b/src/ptsematest/ptsematest.c @@ -389,12 +389,12 @@ int main(int argc, char *argv[]) (int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5), receiver[i].maxdiff); if (receiver[i].error[0] != '\0') { - printf(receiver[i].error); + printf("%s", receiver[i].error); errorlines++; receiver[i].error[0] = '\0'; } if (sender[i].error[0] != '\0') { - printf(sender[i].error); + printf("%s", sender[i].error); errorlines++; receiver[i].error[0] = '\0'; } diff --git a/src/sigwaittest/sigwaittest.c b/src/sigwaittest/sigwaittest.c index 1948d76..428f5ce 100644 --- a/src/sigwaittest/sigwaittest.c +++ b/src/sigwaittest/sigwaittest.c @@ -561,12 +561,12 @@ int main(int argc, char *argv[]) receiver[i].samples) + 0.5), receiver[i].maxdiff); if (receiver[i].error[0] != '\0') { - printf(receiver[i].error); + printf("%s", receiver[i].error); receiver[i].error[0] = '\0'; errorlines++; } if (sender[i].error[0] != '\0') { - printf(sender[i].error); + printf("%s", sender[i].error); sender[i].error[0] = '\0'; errorlines++; } diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c index 89473a5..c1128cc 100644 --- a/src/svsematest/svsematest.c +++ b/src/svsematest/svsematest.c @@ -646,12 +646,12 @@ int main(int argc, char *argv[]) receiver[i].samples) + 0.5), receiver[i].maxdiff); if (receiver[i].error[0] != '\0') { - printf(receiver[i].error); + printf("%s", receiver[i].error); receiver[i].error[0] = '\0'; errorlines++; } if (sender[i].error[0] != '\0') { - printf(sender[i].error); + printf("%s", sender[i].error); sender[i].error[0] = '\0'; errorlines++; } |