aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlec Brown <alec.r.brown@oracle.com>2022-03-21 02:29:02 -0400
committerDaniel Kiper <daniel.kiper@oracle.com>2022-04-04 20:28:54 +0200
commit23c3cbe1dba4fd0c6dc8156bd628d3162e63408d (patch)
tree5180be852aea140dd3ed3276d6a80e22963a6bdc
parent6bb551db112a6d7509d5633be103fe3ee1e09f37 (diff)
downloadgrub-23c3cbe1dba4fd0c6dc8156bd628d3162e63408d.tar.gz
net/bootp: Fix uninitialized scalar variable
In the function grub_net_configure_by_dhcp_ack(), grub_net_network_level_address_t addr is called but isn't being initialized. This results in the member grub_dns_option_t option being filled with junk data from the stack. To prevent this, we can set the option member in addr to 0. Fixes: CID 375036 Signed-off-by: Alec Brown <alec.r.brown@oracle.com> Reviewed-by: Darren Kenny <darren.kenny@oracle.com> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
-rw-r--r--grub-core/net/bootp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c
index 8dc14794d..7d31dba97 100644
--- a/grub-core/net/bootp.c
+++ b/grub-core/net/bootp.c
@@ -244,6 +244,7 @@ grub_net_configure_by_dhcp_ack (const char *name,
addr.type = GRUB_NET_NETWORK_LEVEL_PROTOCOL_IPV4;
addr.ipv4 = bp->your_ip;
+ addr.option = 0;
if (device)
*device = 0;