aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2018-03-26 18:33:49 +0800
committerBen Hutchings <ben@decadent.org.uk>2020-03-28 21:42:54 +0000
commit4265f8d559e294cc39afce8cc6849341db751b0b (patch)
tree0f520b92b67c25965aef7f4f59784447b0469a49
parenta38ba2beea4bb2eea36e687d2527ddb78717ea42 (diff)
downloadklibc-4265f8d559e294cc39afce8cc6849341db751b0b.tar.gz
[klibc] dash: redir: Fix typo in noclobber code
[ dash commit c22e9cc693a6271533740abd9be1bf918a40b0b3 ] The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--usr/dash/redir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/usr/dash/redir.c b/usr/dash/redir.c
index f96a76bc442fc..71b0f77412bf4 100644
--- a/usr/dash/redir.c
+++ b/usr/dash/redir.c
@@ -192,7 +192,7 @@ openredirect(union node *redir)
} else if (!S_ISREG(sb.st_mode)) {
if ((f = open64(fname, O_WRONLY, 0666)) < 0)
goto ecreate;
- if (fstat64(f, &sb) < 0 && S_ISREG(sb.st_mode)) {
+ if (!fstat64(f, &sb) && S_ISREG(sb.st_mode)) {
close(f);
errno = EEXIST;
goto ecreate;