diff options
author | Matthew McClain <mmcclain@noprivs.com> | 2023-10-18 19:25:58 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-10-19 10:57:44 -0700 |
commit | 10c89a02b046e67c861f226064180c4f978a9cc3 (patch) | |
tree | 4787120036a7d6c3431f334a9bfb4a5f625e4f07 | |
parent | 43c8a30d150ecede9709c1f2527c8fba92c65f40 (diff) | |
download | git-10c89a02b046e67c861f226064180c4f978a9cc3.tar.gz |
git-p4 shouldn't attempt to store symlinks in LFS
git-p4.py would attempt to put a symlink in LFS if its file extension
matched git-p4.largeFileExtensions.
Git LFS doesn't store symlinks because smudge/clean filters don't handle
symlinks. They never get passed to the filter process nor the
smudge/clean filters, nor could that occur without a change to the
protocol or command-line interface. Unless Git learned how to send them
to the filters, Git LFS would have a hard time using them in any useful
way.
Git LFS's goal is to move large files out of the repository history, and
symlinks are functionally limited to 4 KiB or a similar size on most
systems.
Signed-off-by: Matthew McClain <mmcclain@noprivs.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-x | git-p4.py | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -1522,6 +1522,10 @@ class LargeFileSystem(object): file is stored in the large file system and handles all necessary steps. """ + # symlinks aren't processed by smudge/clean filters + if git_mode == "120000": + return (git_mode, contents) + if self.exceedsLargeFileThreshold(relPath, contents) or self.hasLargeFileExtension(relPath): contentTempFile = self.generateTempFile(contents) pointer_git_mode, contents, localLargeFile = self.generatePointer(contentTempFile) |