aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2024-02-08 16:22:05 -0800
committerJunio C Hamano <gitster@pobox.com>2024-02-08 16:22:05 -0800
commit1685e9ffe664e834c3d2d7a28144f3e52c0add4f (patch)
tree17459c3bef83e1d390ff094ff2e486acf97a34cc
parent3c2ee131f88c2e65bfed514b7b164f542b046c0c (diff)
parentd70f554cdf38b0b05cfaa8e8eb9f80d54a5ae11c (diff)
downloadgit-1685e9ffe664e834c3d2d7a28144f3e52c0add4f.tar.gz
Merge branch 'jk/commit-graph-slab-clear-fix' into maint-2.43
Clearing in-core repository (happens during e.g., "git fetch --recurse-submodules" with commit graph enabled) made in-core commit object in an inconsistent state by discarding the necessary data from commit-graph too early, which has been corrected. * jk/commit-graph-slab-clear-fix: commit-graph: retain commit slab when closing NULL commit_graph
-rw-r--r--commit-graph.c3
-rwxr-xr-xt/t5510-fetch.sh3
2 files changed, 5 insertions, 1 deletions
diff --git a/commit-graph.c b/commit-graph.c
index a712917356..f2def8bb49 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -831,6 +831,9 @@ struct bloom_filter_settings *get_bloom_filter_settings(struct repository *r)
void close_commit_graph(struct raw_object_store *o)
{
+ if (!o->commit_graph)
+ return;
+
clear_commit_graph_data_slab(&commit_graph_data_slab);
free_commit_graph(o->commit_graph);
o->commit_graph = NULL;
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index dcadd56d3a..91e87b1dd3 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -802,7 +802,8 @@ test_expect_success 'fetch.writeCommitGraph with submodules' '
cd super-clone &&
rm -rf .git/objects/info &&
git -c fetch.writeCommitGraph=true fetch origin &&
- test_path_is_file .git/objects/info/commit-graphs/commit-graph-chain
+ test_path_is_file .git/objects/info/commit-graphs/commit-graph-chain &&
+ git -c fetch.writeCommitGraph=true fetch --recurse-submodules origin
)
'