From b91ba64904a6a05d619a27a17545163eac97c2ca Mon Sep 17 00:00:00 2001 From: Luc Van Oostenryck Date: Sat, 20 Mar 2021 15:42:19 +0100 Subject: memops: avoid using first_pseudo() The loop in rewrite_load_instruction() uses first_pseudo() to not have to special case the first element. But this slightly complicates further changes. So, simply use a null-or-no-null test inside the loop to identify this first element. Signed-off-by: Luc Van Oostenryck --- memops.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/memops.c b/memops.c index d1a9b660..67f37f79 100644 --- a/memops.c +++ b/memops.c @@ -19,15 +19,17 @@ static void rewrite_load_instruction(struct instruction *insn, struct pseudo_list *dominators) { - pseudo_t new, phi; + pseudo_t new = NULL; + pseudo_t phi; /* * Check for somewhat common case of duplicate * phi nodes. */ - new = first_pseudo(dominators)->def->phi_src; FOR_EACH_PTR(dominators, phi) { - if (new != phi->def->phi_src) + if (!new) + new = phi->def->phi_src; + else if (new != phi->def->phi_src) goto complex_phi; } END_FOR_EACH_PTR(phi); -- cgit 1.2.3-korg