From 86edd142e6fa4483cf5cb057ffac4cb548a9374c Mon Sep 17 00:00:00 2001 From: Luc Van Oostenryck Date: Sun, 12 Apr 2020 10:37:58 +0200 Subject: bad-goto: simplify testing of undeclared labels There is no need to do a lookup: checking if the label's symbol is in the NS_LABEL namespace and is lacking an associated statement is enough and much simpler. Signed-off-by: Luc Van Oostenryck --- evaluate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/evaluate.c b/evaluate.c index 4bdd5ed0..d4b46227 100644 --- a/evaluate.c +++ b/evaluate.c @@ -3747,7 +3747,8 @@ static void evaluate_goto_statement(struct statement *stmt) evaluate_expression(stmt->goto_expression); return; } - if (!label->stmt && label->ident && !lookup_keyword(label->ident, NS_KEYWORD)) { + + if (label->namespace == NS_LABEL && !label->stmt) { sparse_error(stmt->pos, "label '%s' was not declared", show_ident(label->ident)); } } -- cgit 1.2.3-korg