From 094d5a948d8c3d8c36f26f14c03cccae66e053a1 Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Thu, 27 Feb 2020 16:21:15 +0100 Subject: dissect: enforce toplevel() if SYM_STRUCT was not defined A separate change for documentation purposes. Test-case: void func(void) { struct UNDEFINED x; x.member = 0; } output: 1:6 def f func void ( ... ) 3:26 func def . v x struct UNDEFINED 4:9 func -w- . v x struct UNDEFINED 4:10 func -w- . m UNDEFINED.member bad type but in this case is_sym_local(UNDEFINED) = F makes more sense, most probably this struct was defined somewhere else but __sparse() didn't see its definition. Change lookup_member() to set type->scope = file_scope if !symbol_list. This is not 100% correct, but struct_union_enum_specifier() does the same check with the following comment: // The following test is actually wrong for empty // structs, but (1) they are not C99, (2) gcc does // the same thing, and (3) it's easier. Signed-off-by: Oleg Nesterov Signed-off-by: Luc Van Oostenryck --- dissect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dissect.c b/dissect.c index c48214b9..1970e46f 100644 --- a/dissect.c +++ b/dissect.c @@ -304,6 +304,9 @@ static struct symbol *lookup_member(struct symbol *type, struct ident *name, int .kind = 'm', }; + if (!type->symbol_list) + type->scope = file_scope; + mem = &bad_member; mem->ident = name; } -- cgit 1.2.3-korg