From 75c5952aece63d5c90b2adfeaff4cb77e3a47520 Mon Sep 17 00:00:00 2001 From: Luc Van Oostenryck Date: Fri, 9 Apr 2021 14:44:37 +0200 Subject: linear: only allocate call instructions when needed When linearizing a call expression, the corresponding instruction is allocated very early: - before the valdity are done - before the linearization is handled to one of the specific methods In both case it means that the allocated instruction is not used. Fix this by doing the allocation only once it's needed. Signed-off-by: Luc Van Oostenryck --- linearize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linearize.c b/linearize.c index 7248fa56..cf87545c 100644 --- a/linearize.c +++ b/linearize.c @@ -1533,7 +1533,7 @@ static pseudo_t linearize_assignment(struct entrypoint *ep, struct expression *e static pseudo_t linearize_call_expression(struct entrypoint *ep, struct expression *expr) { struct expression *arg, *fn; - struct instruction *insn = alloc_typed_instruction(OP_CALL, expr->ctype); + struct instruction *insn; pseudo_t retval, call; struct ctype *ctype = NULL; struct symbol *fntype; @@ -1554,6 +1554,7 @@ static pseudo_t linearize_call_expression(struct entrypoint *ep, struct expressi ctype = &fntype->ctype; + insn = alloc_typed_instruction(OP_CALL, expr->ctype); add_symbol(&insn->fntypes, fntype); FOR_EACH_PTR(expr->args, arg) { pseudo_t new = linearize_expression(ep, arg); -- cgit 1.2.3-korg