diff options
author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2018-05-07 20:31:56 +0200 |
---|---|---|
committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2018-10-05 03:29:19 +0200 |
commit | c7f7ccfcf1888965a0dcfccb4f4466ce22b3eeb9 (patch) | |
tree | 014c62b93524349e5adc844986d636737dadf599 | |
parent | 56a8674803a512f846a059288f3524b2ee7a950f (diff) | |
download | sparse-c7f7ccfcf1888965a0dcfccb4f4466ce22b3eeb9.tar.gz |
enum: warn when mixing different restricted types
Sparse supports enum initializers with bitwise types but
this makes sense only if they are all the same type.
Add a check and issue a warning if an enum is initialized
with different restricted types.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
-rw-r--r-- | parse.c | 5 | ||||
-rw-r--r-- | validation/enum-bitwise-bad.c | 20 |
2 files changed, 25 insertions, 0 deletions
@@ -920,6 +920,11 @@ static struct token *parse_enum_declaration(struct token *token, struct symbol * if (!mix_bitwise++) { warning(expr->pos, "mixed bitwiseness"); } + } else if (is_restricted_type(base_type) && base_type != ctype) { + sparse_error(expr->pos, "incompatible restricted type"); + info(expr->pos, " expected: %s", show_typename(base_type)); + info(expr->pos, " got: %s", show_typename(ctype)); + base_type = &bad_ctype; } else base_type = &bad_ctype; parent->ctype.base_type = base_type; diff --git a/validation/enum-bitwise-bad.c b/validation/enum-bitwise-bad.c new file mode 100644 index 00000000..6d31ca38 --- /dev/null +++ b/validation/enum-bitwise-bad.c @@ -0,0 +1,20 @@ +#define __bitwise __attribute__((bitwise)) +#define __force __attribute__((force)) + +typedef int __bitwise apple_t; +typedef int __bitwise orange_t; + +enum fruit { + A = (__force apple_t) 0, + B = (__force orange_t) 1, +}; + +/* + * check-name: enum-bitwise-bad + * + * check-error-start +enum-bitwise-bad.c:9:14: error: incompatible restricted type +enum-bitwise-bad.c:9:14: expected: restricted apple_t +enum-bitwise-bad.c:9:14: got: restricted orange_t + * check-error-end + */ |