diff options
author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-06-21 21:25:03 +0200 |
---|---|---|
committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-06-23 00:34:09 +0200 |
commit | cc651aa7b6a01c3d89d1eb212a080d683f2df9ed (patch) | |
tree | 082ea55e6f8b95e5d8f081cb4b01d55c2ab5d3e4 | |
parent | b24508f10b9a24b01bd41289f440942ff79b197e (diff) | |
download | sparse-cc651aa7b6a01c3d89d1eb212a080d683f2df9ed.tar.gz |
gensel: remove unneeded test/uninitialized warning
When evaluation generic selections, it is tested if the type in
the selection is a SYM_NODE or not, but:
* all these are SYM_NODE
* the variable for the base type would be uninitialized
if not a SYM_NODE.
So, remove the test and unconditionally set the base type.
Reported-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
-rw-r--r-- | evaluate.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -3304,9 +3304,7 @@ static struct symbol *evaluate_generic_selection(struct expression *expr) if (!evaluate_symbol(stype)) continue; - if (stype->type == SYM_NODE) - base = stype->ctype.base_type; - + base = stype->ctype.base_type; if (base->type == SYM_ARRAY && base->array_size) { get_expression_value_silent(base->array_size); if (base->array_size->type == EXPR_VALUE) |