diff options
author | Oleg Nesterov <oleg@redhat.com> | 2020-02-12 11:04:37 +0100 |
---|---|---|
committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-02-13 18:32:38 +0100 |
commit | 4201c46a529024189737323a4b35b1360a33313c (patch) | |
tree | 168193ac74622a47b3748f81a0aaa7d08c6d3fe0 | |
parent | 9f207728de61eb503613dd960ff75aaa3fb73b36 (diff) | |
download | sparse-4201c46a529024189737323a4b35b1360a33313c.tar.gz |
dissect: kill no_member()
It is trivial and has a single caller, lookup_member().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
-rw-r--r-- | dissect.c | 29 |
1 files changed, 14 insertions, 15 deletions
@@ -119,19 +119,6 @@ static usage_t fix_mode(struct symbol *type, usage_t mode) return mode; } -static inline struct symbol *no_member(struct ident *name) -{ - static struct symbol sym = { - .type = SYM_BAD, - .ctype.base_type = &bad_ctype, - .kind = 'm', - }; - - sym.ident = name; - - return &sym; -} - static struct symbol *report_member(usage_t mode, struct position *pos, struct symbol *type, struct symbol *mem) { @@ -308,8 +295,20 @@ found: static struct symbol *lookup_member(struct symbol *type, struct ident *name, int *addr) { - return __lookup_member(type, name, addr) - ?: no_member(name); + struct symbol *mem = __lookup_member(type, name, addr); + + if (!mem) { + static struct symbol bad_member = { + .type = SYM_BAD, + .ctype.base_type = &bad_ctype, + .kind = 'm', + }; + + mem = &bad_member; + mem->ident = name; + } + + return mem; } static struct expression *peek_preop(struct expression *expr, int op) |