aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>2020-06-23 01:17:57 +0200
committerLuc Van Oostenryck <luc.vanoostenryck@gmail.com>2020-06-23 01:34:11 +0200
commitfa15396204a796135f71b5aef6cbbe3ba1fc0eb3 (patch)
tree41b58a8848bfaa181612278be11244416a4f47d5
parent44936538b1f956c524ba063eb3f1efaf0f92dae1 (diff)
downloadsparse-fa15396204a796135f71b5aef6cbbe3ba1fc0eb3.tar.gz
testsuite: fix 'format help' / validate number of arguments
The subcommand 'format help' is broken because the of the way arguments are parsed without validating the number of arguments. Fix this by parsing all arguments (even if there is only one) and validate the number of arguments at the end of the loop. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
-rwxr-xr-xvalidation/test-suite7
1 files changed, 6 insertions, 1 deletions
diff --git a/validation/test-suite b/validation/test-suite
index a22f7013..d351ebf3 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -474,7 +474,7 @@ do_format()
linear=0
fail=0
- while [ $# -gt 1 ] ; do
+ while [ $# -gt 0 ] ; do
case "$1" in
-a)
append=1 ;;
@@ -493,6 +493,11 @@ do_format()
continue
done
+ if [ $# -lt 1 -o $# -gt 3 ]; then
+ do_format_help
+ return 0
+ fi
+
arg_file "$1" || return 1
file="$1"