diff options
author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-08-08 06:25:40 +0200 |
---|---|---|
committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-08-08 15:36:51 +0200 |
commit | 446313222a0b47504d162a1e67527fb517275096 (patch) | |
tree | f329fccac9a70db8414a0ad0603253bebe105e57 | |
parent | ce8785f0a92426cc2039a00e9fc8699b5e7d3ce1 (diff) | |
download | sparse-446313222a0b47504d162a1e67527fb517275096.tar.gz |
wstring: extend is_string_type() to also detect wide strings
When evaluating initializers, it must be known if it is for a string
or not. But sparse doesn't known about wide strings.
Fix this by modifying is_string_type() to use is_wchar_type()
in addition of is_byte_type().
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
-rw-r--r-- | evaluate.c | 5 | ||||
-rw-r--r-- | validation/init-wstring.c | 1 |
2 files changed, 4 insertions, 2 deletions
@@ -406,7 +406,10 @@ static inline int is_string_type(struct symbol *type) { if (type->type == SYM_NODE) type = type->ctype.base_type; - return type->type == SYM_ARRAY && is_byte_type(type->ctype.base_type); + if (type->type != SYM_ARRAY) + return 0; + type = type->ctype.base_type; + return is_byte_type(type) || is_wchar_type(type); } static struct symbol *bad_expr_type(struct expression *expr) diff --git a/validation/init-wstring.c b/validation/init-wstring.c index 846b6e2c..d9ce3b3c 100644 --- a/validation/init-wstring.c +++ b/validation/init-wstring.c @@ -32,7 +32,6 @@ static const __WCHAR_TYPE__ ko2[2] = L"abc"; /* * check-name: init-wstring * check-command: sparse -Winit-cstring $file - * check-known-to-fail * * check-error-start init-wstring.c:29:38: warning: too long initializer-string for array of char(no space for nul char) |