diff options
| author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2019-12-24 10:26:46 +0100 |
|---|---|---|
| committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2020-10-23 01:28:28 +0200 |
| commit | eedd7112255f6900e2fea8ea312c32acf04e2bc7 (patch) | |
| tree | f77456e2e691e9a70f862765fadad661e3182b5d | |
| parent | cfca7b4c6cb48283cb554fc91dc859ff669f2547 (diff) | |
| download | sparse-eedd7112255f6900e2fea8ea312c32acf04e2bc7.tar.gz | |
cleanup linearize_cond_branch()
No functional changes here, just some more consistency:
* systematically use break instead of 'return VOID'
* remove some superfluous curlies
* remove some unneeded blank lines
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
| -rw-r--r-- | linearize.c | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/linearize.c b/linearize.c index 1081bda8..978d1e41 100644 --- a/linearize.c +++ b/linearize.c @@ -1795,37 +1795,30 @@ static pseudo_t linearize_cond_branch(struct entrypoint *ep, struct expression * case EXPR_STRING: case EXPR_VALUE: add_goto(ep, expr->value ? bb_true : bb_false); - return VOID; - + break; case EXPR_FVALUE: add_goto(ep, expr->fvalue ? bb_true : bb_false); - return VOID; - + break; case EXPR_LOGICAL: linearize_logical_branch(ep, expr, bb_true, bb_false); - return VOID; - + break; case EXPR_COMPARE: cond = linearize_compare(ep, expr); add_branch(ep, cond, bb_true, bb_false); break; - case EXPR_PREOP: if (expr->op == '!') return linearize_cond_branch(ep, expr->unop, bb_false, bb_true); /* fall through */ - default: { + default: cond = linearize_expression_to_bool(ep, expr); add_branch(ep, cond, bb_true, bb_false); - - return VOID; - } + break; } return VOID; } - static pseudo_t linearize_logical_branch(struct entrypoint *ep, struct expression *expr, struct basic_block *bb_true, struct basic_block *bb_false) { struct basic_block *next = alloc_basic_block(ep, expr->pos); |