diff -Naur -X linux-2.6.31-rc5-git3-driver-core.current/Documentation/dontdiff linux-2.6.31-rc5-git3-driver-core.current/drivers/isdn/gigaset/interface.c linux-2.6.31-rc5-git3-tty.current/drivers/isdn/gigaset/interface.c --- linux-2.6.31-rc5-git3-driver-core.current/drivers/isdn/gigaset/interface.c 2009-07-31 21:21:52.000000000 -0700 +++ linux-2.6.31-rc5-git3-tty.current/drivers/isdn/gigaset/interface.c 2009-08-07 17:38:43.000000000 -0700 @@ -408,33 +408,28 @@ return retval; } -/* FIXME: This function does not have error returns */ - static int if_chars_in_buffer(struct tty_struct *tty) { struct cardstate *cs; - int retval = -ENODEV; + int retval = 0; cs = (struct cardstate *) tty->driver_data; if (!cs) { pr_err("%s: no cardstate\n", __func__); - return -ENODEV; + return 0; } gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__); - if (mutex_lock_interruptible(&cs->mutex)) - return -ERESTARTSYS; // FIXME -EINTR? + mutex_lock(&cs->mutex); - if (!cs->connected) { + if (!cs->connected) gig_dbg(DEBUG_IF, "not connected"); - retval = -ENODEV; - } else if (!cs->open_count) + else if (!cs->open_count) dev_warn(cs->dev, "%s: device not opened\n", __func__); - else if (cs->mstate != MS_LOCKED) { + else if (cs->mstate != MS_LOCKED) dev_warn(cs->dev, "can't write to unlocked device\n"); - retval = -EBUSY; - } else + else retval = cs->ops->chars_in_buffer(cs); mutex_unlock(&cs->mutex); diff -Naur -X linux-2.6.31-rc5-git3-driver-core.current/Documentation/dontdiff linux-2.6.31-rc5-git3-driver-core.current/drivers/serial/bfin_5xx.c linux-2.6.31-rc5-git3-tty.current/drivers/serial/bfin_5xx.c --- linux-2.6.31-rc5-git3-driver-core.current/drivers/serial/bfin_5xx.c 2009-07-31 21:21:55.000000000 -0700 +++ linux-2.6.31-rc5-git3-tty.current/drivers/serial/bfin_5xx.c 2009-08-07 17:38:43.000000000 -0700 @@ -42,6 +42,10 @@ # undef CONFIG_EARLY_PRINTK #endif +#ifdef CONFIG_SERIAL_BFIN_MODULE +# undef CONFIG_EARLY_PRINTK +#endif + /* UART name and device definitions */ #define BFIN_SERIAL_NAME "ttyBF" #define BFIN_SERIAL_MAJOR 204