arch/i386/kernel/io_apic.c: In function `balanced_irq': arch/i386/kernel/io_apic.c:582: warning: no return statement in function returning non-void and clean things up a bit Signed-off-by: Andrew Morton --- 25-akpm/arch/i386/kernel/io_apic.c | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-) diff -puN arch/i386/kernel/io_apic.c~balanced_irq-warning-fix arch/i386/kernel/io_apic.c --- 25/arch/i386/kernel/io_apic.c~balanced_irq-warning-fix 2004-06-23 22:38:55.289105744 -0700 +++ 25-akpm/arch/i386/kernel/io_apic.c 2004-06-23 22:40:09.958754232 -0700 @@ -555,7 +555,7 @@ not_worth_the_effort: return; } -int balanced_irq(void *unused) +static int balanced_irq(void *unused) { int i; unsigned long prev_balance_time = jiffies; @@ -568,17 +568,17 @@ int balanced_irq(void *unused) pending_irq_balance_cpumask[i] = cpumask_of_cpu(0); } -repeat: - set_current_state(TASK_INTERRUPTIBLE); - time_remaining = schedule_timeout(time_remaining); - if (time_after(jiffies, prev_balance_time+balanced_irq_interval)) { - Dprintk("balanced_irq: calling do_irq_balance() %lu\n", - jiffies); - do_irq_balance(); - prev_balance_time = jiffies; - time_remaining = balanced_irq_interval; + for ( ; ; ) { + set_current_state(TASK_INTERRUPTIBLE); + time_remaining = schedule_timeout(time_remaining); + if (time_after(jiffies, + prev_balance_time+balanced_irq_interval)) { + do_irq_balance(); + prev_balance_time = jiffies; + time_remaining = balanced_irq_interval; + } } - goto repeat; + return 0; } static int __init balanced_irq_init(void) _