From: Jesper Juhl Convert check_region to request_region and clean up some parentheses in return statements for drivers/cdrom/isp16.c. Signed-off-by: Jesper Juhl Signed-off-by: Andrew Morton --- 25-akpm/drivers/cdrom/isp16.c | 45 +++++++++++++++++++++++++----------------- 1 files changed, 27 insertions(+), 18 deletions(-) diff -puN drivers/cdrom/isp16.c~isp16-check_region-removal drivers/cdrom/isp16.c --- 25/drivers/cdrom/isp16.c~isp16-check_region-removal 2004-06-19 14:10:22.588927200 -0700 +++ 25-akpm/drivers/cdrom/isp16.c 2004-06-19 14:10:22.592926592 -0700 @@ -16,6 +16,10 @@ * module_init & module_exit. * Torben Mathiasen * + * 19 June 2004 -- check_region() converted to request_region() + * and return statement cleanups. + * Jesper Juhl + * * Detect cdrom interface on ISP16 sound card. * Configure cdrom interface. * @@ -118,17 +122,17 @@ int __init isp16_init(void) if (!strcmp(isp16_cdrom_type, "noisp16")) { printk("ISP16: no cdrom interface configured.\n"); - return (0); + return 0; } - if (check_region(ISP16_IO_BASE, ISP16_IO_SIZE)) { + if (!request_region(ISP16_IO_BASE, ISP16_IO_SIZE, "isp16")) { printk("ISP16: i/o ports already in use.\n"); - return (-EIO); + goto out; } if ((isp16_type = isp16_detect()) < 0) { printk("ISP16: no cdrom interface found.\n"); - return (-EIO); + goto cleanup_out; } printk(KERN_INFO @@ -148,27 +152,32 @@ int __init isp16_init(void) else { printk("ISP16: %s not supported by cdrom interface.\n", isp16_cdrom_type); - return (-EIO); + goto cleanup_out; } if (isp16_cdi_config(isp16_cdrom_base, expected_drive, isp16_cdrom_irq, isp16_cdrom_dma) < 0) { printk ("ISP16: cdrom interface has not been properly configured.\n"); - return (-EIO); + goto cleanup_out; } printk(KERN_INFO "ISP16: cdrom interface set up with io base 0x%03X, irq %d, dma %d," " type %s.\n", isp16_cdrom_base, isp16_cdrom_irq, isp16_cdrom_dma, isp16_cdrom_type); - return (0); + return 0; + +cleanup_out: + release_region(ISP16_IO_BASE, ISP16_IO_SIZE); +out: + return -EIO; } static short __init isp16_detect(void) { if (isp16_c929__detect() >= 0) - return (2); + return 2; else return (isp16_c928__detect()); } @@ -206,7 +215,7 @@ static short __init isp16_c928__detect(v ISP16_OUT(ISP16_C928__ENABLE_PORT, enable_cdrom); } else { /* bits are not the same */ ISP16_OUT(ISP16_CTRL_PORT, ctrl); - return (i); /* -> not detected: possibly incorrect conclusion */ + return i; /* -> not detected: possibly incorrect conclusion */ } } else if (enable_cdrom == 0x20) i = 0; @@ -215,7 +224,7 @@ static short __init isp16_c928__detect(v ISP16_OUT(ISP16_CTRL_PORT, ctrl); - return (i); + return i; } static short __init isp16_c929__detect(void) @@ -236,12 +245,12 @@ static short __init isp16_c929__detect(v tmp = ISP16_IN(ISP16_CTRL_PORT); if (tmp != 2) /* isp16 with 82C929 not detected */ - return (-1); + return -1; /* restore ctrl port value */ ISP16_OUT(ISP16_CTRL_PORT, ctrl); - return (2); + return 2; } static short __init @@ -272,7 +281,7 @@ isp16_cdi_config(int base, u_char drive_ printk ("ISP16: base address 0x%03X not supported by cdrom interface.\n", base); - return (-1); + return -1; } switch (irq) { case 0: @@ -303,7 +312,7 @@ isp16_cdi_config(int base, u_char drive_ default: printk("ISP16: irq %d not supported by cdrom interface.\n", irq); - return (-1); + return -1; } switch (dma) { case 0: @@ -312,7 +321,7 @@ isp16_cdi_config(int base, u_char drive_ case 1: printk("ISP16: dma 1 cannot be used by cdrom interface," " due to conflict with the sound card.\n"); - return (-1); + return -1; break; case 3: dma_code = ISP16_DMA_3; @@ -329,7 +338,7 @@ isp16_cdi_config(int base, u_char drive_ default: printk("ISP16: dma %d not supported by cdrom interface.\n", dma); - return (-1); + return -1; } if (drive_type != ISP16_SONY && drive_type != ISP16_PANASONIC0 && @@ -339,7 +348,7 @@ isp16_cdi_config(int base, u_char drive_ printk ("ISP16: drive type (code 0x%02X) not supported by cdrom" " interface.\n", drive_type); - return (-1); + return -1; } /* set type of interface */ @@ -354,7 +363,7 @@ isp16_cdi_config(int base, u_char drive_ i = ISP16_IN(ISP16_IO_SET_PORT) & ISP16_IO_SET_MASK; /* keep some bits */ ISP16_OUT(ISP16_IO_SET_PORT, i | base_code | irq_code | dma_code); - return (0); + return 0; } void __exit isp16_exit(void) _