From: NeilBrown We can be a little more concise here. Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown Signed-off-by: Andrew Morton --- fs/nfsd/nfs4state.c | 14 ++------------ 1 files changed, 2 insertions(+), 12 deletions(-) diff -puN fs/nfsd/nfs4state.c~nfsd4-setclientid-simplification fs/nfsd/nfs4state.c --- 25/fs/nfsd/nfs4state.c~nfsd4-setclientid-simplification Thu Jun 2 16:25:09 2005 +++ 25-akpm/fs/nfsd/nfs4state.c Thu Jun 2 16:25:09 2005 @@ -674,23 +674,13 @@ nfsd4_setclientid(struct svc_rqst *rqstp * or different ip_address */ status = nfserr_clid_inuse; - if (!cmp_creds(&clp->cl_cred,&rqstp->rq_cred)) { + if (!cmp_creds(&clp->cl_cred,&rqstp->rq_cred) + || clp->cl_addr != ip_addr) { printk("NFSD: setclientid: string in use by client" "(clientid %08x/%08x)\n", clp->cl_clientid.cl_boot, clp->cl_clientid.cl_id); goto out; } - if (clp->cl_addr != ip_addr) { - printk("NFSD: setclientid: string in use by client" - "(clientid %08x/%08x)\n", - clp->cl_clientid.cl_boot, clp->cl_clientid.cl_id); - goto out; - } - - /* - * cl_name match from a previous SETCLIENTID operation - * XXX check for additional matches? - */ conf = clp; break; } _